refactor(ci): extract helm functions to lib/helm.sh#4118
Merged
openshift-merge-bot[bot] merged 3 commits intoredhat-developer:mainfrom Jan 30, 2026
Merged
refactor(ci): extract helm functions to lib/helm.sh#4118openshift-merge-bot[bot] merged 3 commits intoredhat-developer:mainfrom
openshift-merge-bot[bot] merged 3 commits intoredhat-developer:mainfrom
Conversation
Extract Helm chart operations and value file manipulation functions from utils.sh into a dedicated lib/helm.sh module. Functions extracted: - yq_merge_value_files -> helm::merge_values - uninstall_helmchart -> helm::uninstall - get_image_helm_set_params -> helm::get_image_params - perform_helm_install -> helm::install - get_chart_version -> helm::get_chart_version - get_previous_release_value_file -> helm::get_previous_release_values Backward compatibility is maintained through alias functions that delegate to the new namespaced functions. Jira: RHIDP-11009 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add explicit return statements to satisfy SonarCloud code quality checks. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Member
Author
|
/test ? |
Member
Author
|
/test e2e-ocp-helm-nightly |
Contributor
|
The image is available at: |
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: albarbaro The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit 9941e8e
into
redhat-developer:main
20 checks passed
This was referenced Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract Helm chart operations and value file manipulation functions from
utils.shinto a dedicatedlib/helm.shmodule as part of the CI refactoring effort.Changes
lib/helm.shwith 6 extracted functions:helm::merge_values(fromyq_merge_value_files)helm::uninstall(fromuninstall_helmchart)helm::get_image_params(fromget_image_helm_set_params)helm::install(fromperform_helm_install)helm::get_chart_version(fromget_chart_version)helm::get_previous_release_values(fromget_previous_release_value_file)utils.shto import the new moduleutils.shlib/README.mdwith module documentationBackward Compatibility
Alias functions are provided in
lib/helm.shto maintain backward compatibility with existing call sites.Test plan
lib/helm.shJira: RHIDP-11009
🤖 Generated with Claude Code