Skip to content

[release-1.9] test(e2e): add orchestrator RBAC e2e tests#4197

Draft
chadcrum wants to merge 3 commits intoredhat-developer:release-1.9from
chadcrum:add-e2e-orchestrator-rbac-tests-rhdh-1-9-branch
Draft

[release-1.9] test(e2e): add orchestrator RBAC e2e tests#4197
chadcrum wants to merge 3 commits intoredhat-developer:release-1.9from
chadcrum:add-e2e-orchestrator-rbac-tests-rhdh-1-9-branch

Conversation

@chadcrum
Copy link
Contributor

@chadcrum chadcrum commented Feb 4, 2026

Summary

Backport of orchestrator RBAC e2e tests to release-1.9 branch.

  • Cherry-pick of test(e2e): add orchestrator RBAC e2e tests #4009 (orchestrator RBAC e2e test suite)
  • Add 28 comprehensive RBAC tests for Orchestrator plugin covering:
    • Global workflow permissions (read-write, read-only, denied)
    • Individual workflow permissions
    • Workflow instance access control
  • Fix cherry-pick compatibility issues:
    • Add missing shouldSkipOrchestratorTests variable to playwright.config.ts
    • Fix case-sensitive selector in reRunFailSwitchWorkflow()

Test plan

  • Run orchestrator RBAC e2e tests on 1.9 environment
  • Verify tests skip correctly on environments without orchestrator deployed

Notes

⚠️ The RBAC API validation test in rbac.spec.ts is temporarily enabled for testing. It must be changed back to test.fixme before merge (see TODO comment on line 552).

* test(e2e): add orchestrator RBAC e2e test suite

Add comprehensive RBAC end-to-end tests for the Orchestrator plugin
covering workflow and instance access control:

- Read-write access: users can view and execute all workflows
- Read-only access: users can view but not execute workflows
- Denied access: users cannot see any workflows

- Workflow-specific read-write: access only to specific workflow
- Workflow-specific read-only: view only specific workflow
- Workflow-specific denied: hide specific workflow

- Initiator-based access: users can only see their own instances
- Admin override: instanceAdminView grants access to all instances
- Cross-user isolation verification

- Re-enable RBAC API validation test (previously test.fixme)
- Add filtering for dynamically created workflow roles/policies
- Prevents test interference during parallel execution

- Add waitForWorkflowVisible() helper with configurable timeout
- Add timeout parameter to selectGreetingWorkflowItem()
- Add timeout parameter to selectFailSwitchWorkflowItem()
- Handles RBAC permission propagation delay

- orchestrator.workflow / orchestrator.workflow.<id> (read)
- orchestrator.workflow.use / orchestrator.workflow.use.<id> (update)
- orchestrator.instanceAdminView (read) - admin access to all instances

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(e2e): skip orchestrator RBAC tests when orchestrator not deployed

Add testIgnore to SHOWCASE_RBAC, SHOWCASE_RBAC_K8S, and SHOWCASE_OPERATOR_RBAC
projects to prevent orchestrator-rbac.spec.ts from running on PR jobs and K8s
environments where orchestrator is not deployed.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
@openshift-ci openshift-ci bot requested review from jrichter1 and psrna February 4, 2026 19:59
@chadcrum chadcrum marked this pull request as draft February 4, 2026 20:00
- Add missing shouldSkipOrchestratorTests variable to playwright.config.ts
- Temporarily enable RBAC API validation test for testing
- Fix case-sensitive selector in reRunFailSwitchWorkflow()
@chadcrum chadcrum force-pushed the add-e2e-orchestrator-rbac-tests-rhdh-1-9-branch branch from bd6aadd to 0eb25cf Compare February 4, 2026 20:05
@chadcrum
Copy link
Contributor Author

chadcrum commented Feb 4, 2026

/ok-to-test

@chadcrum
Copy link
Contributor Author

chadcrum commented Feb 4, 2026

/test e2e-ocp-helm-nightly

@rhdh-qodo-merge
Copy link

ⓘ Your monthly quota for Qodo has expired. Upgrade your plan
ⓘ Paying users. Check that your Qodo account is linked with this Git user account

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

@openshift-ci
Copy link

openshift-ci bot commented Feb 4, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign teknas47 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chadcrum
Copy link
Contributor Author

chadcrum commented Feb 4, 2026

/retest

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

🚫 Image Push Skipped.

The container image push was skipped because the build was skipped (either due to [skip-build] tag or no relevant changes with existing image)

@chadcrum
Copy link
Contributor Author

chadcrum commented Feb 4, 2026

/test e2e-ocp-helm-nightly

@rhdh-qodo-merge
Copy link

ⓘ Your monthly quota for Qodo has expired. Upgrade your plan
ⓘ Paying users. Check that your Qodo account is linked with this Git user account

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 4, 2026

@openshift-ci
Copy link

openshift-ci bot commented Feb 5, 2026

@chadcrum: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-helm-nightly 38db545 link false /test e2e-ocp-helm-nightly
ci/prow/e2e-ocp-helm 38db545 link true /test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant