feat(i18n): added de/es translation support#4319
feat(i18n): added de/es translation support#4319openshift-merge-bot[bot] merged 5 commits intoredhat-developer:mainfrom
Conversation
|
The container image build workflow finished with status: |
|
/retest |
|
/retest |
openshift-ci
Bot
requested review from
christoph-jerolimov,
ciiay and
karthikjeeyar
|
/retest |
lokanandaprabhu
force-pushed
the
i18n-de-es-updates
branch
from
7721246 to
6388041
Compare
teknaS47
left a comment
teknaS47
left a comment
There was a problem hiding this comment.
Please update all the JSON files to use respective locales instead of en
| 'table.body.emptyDataSourceMessage': | ||
| 'Keine Datensätze zum Anzeigen vorhanden', | ||
| 'table.pagination.firstTooltip': 'Erste Seite', | ||
| 'table.pagination.labelDisplayedRows': '{von}-{bis} von {Anzahl}', |
There was a problem hiding this comment.
check once if this works as expected?
There was a problem hiding this comment.
This key is used in backstage and in catalog we are not using pagination, I added 22 components and checked
lokanandaprabhu
force-pushed
the
i18n-de-es-updates
branch
from
e4cefb3 to
ca4e22f
Compare
|
The container image build workflow finished with status: |
|
@karthikjeeyar / @invincibleJai , updated the PR based on review comments. PTAL. |
|
/retest |
karthikjeeyar
left a comment
karthikjeeyar
left a comment
There was a problem hiding this comment.
@lokanandaprabhu In backstage-<locale>.json translations files, a new plugin plugin.notifications (translations recently added ) is translated for this deand eslocales, but these are missing in existing frand itlocales,
Could you please create a followup ticket to add translations for missing locales?
Verified the changes in the cluster
|
@christoph-jerolimov / @rohitkrai03 / @kadel @karthikjeeyar approved the PR, need your help in merging this, sonarqubecloud is failed because of duplicates, but for translations we can't do anything for that. |
|
/test e2e-ocp-helm-nightly |
1 similar comment
|
/test e2e-ocp-helm-nightly |
Wire de/es translation resources, add locale files, and align JSON names and overrides for backstage and rhdh translations. Made-with: Cursor
Run prettier on updated translation files to satisfy lint checks. Made-with: Cursor
Replace en locale blocks with de/es in translation JSONs for backstage, community-plugins, and rhdh. Made-with: Cursor
Move catalog translations into translations folder, normalize locale ordering, update JSON namespaces, and add local catalog entities/config to enable pagination checks. Made-with: Cursor
lokanandaprabhu
force-pushed
the
i18n-de-es-updates
branch
from
ca4e22f to
8431191
Compare
|
Rebased the PR with main branch. |
|
/test e2e-ocp-helm-nightly |
1 similar comment
|
/test e2e-ocp-helm-nightly |
Use the search input to narrow templates to Greeting Test Picker for more reliable selection. Made-with: Cursor
|
/test e2e-ocp-helm-nightly |
|
|
/retest /test e2e-ocp-helm-nightly |
|
/retest /test e2e-ocp-helm-nightly |
|
See https://redhat-internal.slack.com/archives/C05KGRQLPLG/p1773306384973009 /approve |
|
@christoph-jerolimov: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-ocp-helm-nightly |
|
@christoph-jerolimov: Overrode contexts on behalf of christoph-jerolimov: ci/prow/e2e-ocp-helm-nightly DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "SonarCloud Code Analysis" |
|
@christoph-jerolimov: Overrode contexts on behalf of christoph-jerolimov: SonarCloud Code Analysis DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
Bot
merged commit fdd1e6a
into
redhat-developer:main
7 participants
Fixes:
https://issues.redhat.com/browse/RHIDP-11752
https://issues.redhat.com/browse/RHIDP-11670
Wire German/Spanish locale files across catalog, scaffolder, search, user-settings, core-components, and catalog-import