Skip to content

chore: increase package size limit#4666

Merged
openshift-merge-bot[bot] merged 2 commits into
redhat-developer:mainfrom
Jdubrick:increase-package-size-limit
Apr 21, 2026
Merged

chore: increase package size limit#4666
openshift-merge-bot[bot] merged 2 commits into
redhat-developer:mainfrom
Jdubrick:increase-package-size-limit

Conversation

@Jdubrick
Copy link
Copy Markdown
Contributor

Description

Please explain the changes you made here.

  • Updates the maximum file size allowed from 20MB --> 40MB
  • Refactors into a constant to reduce duplication

Which issue(s) does this PR fix

N/A

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
@openshift-ci openshift-ci Bot requested review from hopehadfield and josephca April 21, 2026 17:10
@Jdubrick Jdubrick changed the title (chore): Increase package size limit chore: Increase package size limit Apr 21, 2026
@sonarqubecloud
Copy link
Copy Markdown

@Jdubrick Jdubrick changed the title chore: Increase package size limit chore: increase package size limit Apr 21, 2026
Copy link
Copy Markdown
Member

@Zaperex Zaperex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Apr 21, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit d4f996b into redhat-developer:main Apr 21, 2026
14 of 16 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

gustavolira added a commit to gustavolira/rhdh that referenced this pull request May 26, 2026
… the TS implementation

Brings the TS port back in sync with three commits that landed on main while
this PR was open:

- redhat-developer#4576 (OCI disable pre-merge): pre-compute the set of OCI registries that
  will be effectively disabled after merging, then filter them out of every
  plugin list before the merge calls skopeo. Avoids wasted remote fetches
  for plugins the operator already disabled at a higher level. New helpers
  in src/merger.ts (preMergeOciDisabledState, filterDisabledOciPlugins) and
  src/oci-key.ts (tryParseOciRegistryAndPath). loadAllPlugins() in
  src/index.ts now reads every include file up front so the pre-merge pass
  can run before mergePlugin() touches the OCI cache.

- redhat-developer#4666 (MAX_ENTRY_SIZE bump): default from 20MB to 40MB.

- redhat-developer#4655 (EXTRA_CATALOG_INDEX_IMAGES): comma-separated catalog index images,
  each extracted into <CATALOG_ENTITIES_EXTRACT_DIR>/extra/<name>/
  catalog-entities. New helpers in src/catalog-index.ts
  (extractCatalogIndexLayers refactored out of extractCatalogIndex,
  extractExtraCatalogIndex, parseExtraCatalogIndexImages,
  imageRefToSubdirectory). New maybeExtractExtraCatalogIndexes() in
  src/index.ts wires it into runInstaller after the primary catalog index.

Tests: 27 new cases under __tests__/merger-pre-merge.test.ts (15) and
__tests__/extra-catalog-index.test.ts (12) covering the level-override
matrix, ambiguous-pathless detection, same-level duplicates, invalid OCI
strings, extensions/marketplace fallback, missing-entities warning, and
the duplicate-subdir overwrite warning ordering. Existing
tar-extract.test.ts + types.test.ts updated for the new 40MB default. All
155 vitest cases pass. Bundle rebuilt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants