Skip to content

fix(e2e): add the missing assertion [ci-skip] [skip build]#4724

Open
josephca wants to merge 2 commits intoredhat-developer:mainfrom
josephca:fix/unused-locator-extensions
Open

fix(e2e): add the missing assertion [ci-skip] [skip build]#4724
josephca wants to merge 2 commits intoredhat-developer:mainfrom
josephca:fix/unused-locator-extensions

Conversation

@josephca
Copy link
Copy Markdown
Member

Description

Add a missing assertion to fix renovate PR - more strict Lint checkup is added by the updated version.

E2E Tests / TSC, ESLint, ShellCheck and Prettier (pull_request)

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci openshift-ci Bot requested review from kadel and zdrapela April 29, 2026 18:55
@josephca josephca changed the title fix(e2e): add the missing assertion fix(e2e): add the missing assertion [ci-skip] [skip build] Apr 29, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@gustavolira
Copy link
Copy Markdown
Member

/lgtm

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.56%. Comparing base (d326407) to head (b3de3a6).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4724       +/-   ##
===========================================
+ Coverage   40.98%   69.56%   +28.58%     
===========================================
  Files         119      109       -10     
  Lines        2223     4705     +2482     
  Branches      537      511       -26     
===========================================
+ Hits          911     3273     +2362     
- Misses       1307     1432      +125     
+ Partials        5        0        -5     
Flag Coverage Δ
install-dynamic-plugins 92.44% <ø> (?)
rhdh 38.75% <ø> (-2.23%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d326407...b3de3a6. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@openshift-ci openshift-ci Bot removed the lgtm label Apr 29, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 29, 2026

New changes are detected. LGTM label has been removed.

@github-actions
Copy link
Copy Markdown
Contributor

The container image build and publish workflows were skipped (either due to [skip-build] tag or no relevant changes with existing image).

@josephca josephca force-pushed the fix/unused-locator-extensions branch from 3e4b541 to 31344aa Compare April 29, 2026 21:24
@github-actions
Copy link
Copy Markdown
Contributor

The container image build and publish workflows were skipped (either due to [skip-build] tag or no relevant changes with existing image).

@sonarqubecloud
Copy link
Copy Markdown

@josephca
Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

1 similar comment
@josephca
Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 30, 2026

@josephca: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-helm 31344aa link true /test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

@github-actions github-actions Bot added the Stale label May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants