Skip to content

chore(fab): code cleanup for fab plugin removal#5010

Merged
openshift-merge-bot[bot] merged 1 commit into
redhat-developer:mainfrom
ciiay:rhidp-14645-remove-fab-test-cleanup
Jun 25, 2026
Merged

chore(fab): code cleanup for fab plugin removal#5010
openshift-merge-bot[bot] merged 1 commit into
redhat-developer:mainfrom
ciiay:rhidp-14645-remove-fab-test-cleanup

Conversation

@ciiay

@ciiay ciiay commented Jun 24, 2026

Copy link
Copy Markdown
Member

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

This is a follow-up pr for #4920

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Signed-off-by: Yi Cai <yicai@redhat.com>
@openshift-ci openshift-ci Bot requested review from gustavolira and zdrapela June 24, 2026 18:42
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.77%. Comparing base (65bcea6) to head (ab89d07).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5010      +/-   ##
==========================================
- Coverage   55.39%   54.77%   -0.62%     
==========================================
  Files         122      110      -12     
  Lines        2365     2147     -218     
  Branches      539      537       -2     
==========================================
- Hits         1310     1176     -134     
+ Misses       1049      969      -80     
+ Partials        6        2       -4     
Flag Coverage Δ
rhdh 54.77% <ø> (-0.62%) ⬇️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65bcea6...ab89d07. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@its-mitesh-kumar its-mitesh-kumar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jun 25, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 7c2ecd5 into redhat-developer:main Jun 25, 2026
22 checks passed
@sonarqubecloud

Copy link
Copy Markdown

@openshift-ci

openshift-ci Bot commented Jun 25, 2026

Copy link
Copy Markdown

@ciiay: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-helm ab89d07 link unknown /test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants