Skip to content

update language client to adopt call hierarchy#1194

Closed
testforstephen wants to merge 1 commit into
redhat-developer:masterfrom
testforstephen:jinbo_callhierarchy
Closed

update language client to adopt call hierarchy#1194
testforstephen wants to merge 1 commit into
redhat-developer:masterfrom
testforstephen:jinbo_callhierarchy

Conversation

@testforstephen
Copy link
Copy Markdown
Collaborator

Signed-off-by: Jinbo Wang jinbwan@microsoft.com

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
@testforstephen
Copy link
Copy Markdown
Collaborator Author

✓ Extension should be present
rejected promise not handled within 1 second: Error: Message could not be parsed.
stack trace: Error: Message could not be parsed.
at handleResponse (/home/travis/build/redhat-developer/vscode-java/dist/extension.js:53489:48)
at processMessageQueue (/home/travis/build/redhat-developer/vscode-java/dist/extension.js:53316:17)
at Immediate. (/home/travis/build/redhat-developer/vscode-java/dist/extension.js:53300:13)
at processImmediate (internal/timers.js:439:21)

This is the travis ci failure exception. The reason is the language server throws exception during parsing the LSP data.

The tests are using the http://download.eclipse.org/jdtls/snapshots/jdt-language-server-latest.tar.gz bits, which has compatible issue with the latest language client. The language client has changed the diagnostics tagSupport capabilities from Boolean to an array so that the existing language server throws jsonrpc exception during initialization. This will be fixed in the server side call hierarchy PR.

Comment thread src/javaServerStarter.ts
const options: ExecutableOptions = Object.create(null);
options.env = process.env;
options.stdio = 'pipe';
// options.stdio = 'pipe';
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the line altogether

@fbricon
Copy link
Copy Markdown
Collaborator

fbricon commented Dec 18, 2019

merged as 7f005ee

Thanks @testforstephen

@fbricon fbricon closed this Dec 18, 2019
@testforstephen testforstephen deleted the jinbo_callhierarchy branch December 19, 2019 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants