Fix moving refactoring not working in standard mode#2506
Merged
testforstephen merged 2 commits intoredhat-developer:masterfrom Jun 13, 2022
Merged
Fix moving refactoring not working in standard mode#2506testforstephen merged 2 commits intoredhat-developer:masterfrom
testforstephen merged 2 commits intoredhat-developer:masterfrom
Conversation
- return the 'stop()' promise in each 'xxxClient.stop()' method. - return 'Promise.all()' in 'deactivate()' Signed-off-by: sheche <sheche@microsoft.com>
Signed-off-by: sheche <sheche@microsoft.com>
testforstephen
approved these changes
Jun 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2503
Did some refactoring for each language client's stop() method. They still do the real stop stuff as the method name suggests, and the returned promise can be combined in the deactivated() function via
Promise.allSigned-off-by: sheche sheche@microsoft.com