Test collecting lsp4mp extensions#7
Merged
xorye merged 1 commit intoredhat-developer:masterfrom Jul 21, 2020
Merged
Conversation
rzgry
force-pushed
the
test-collect-lsp4mp-extensions
branch
from
17cadf5 to
455051e
Compare
xorye
reviewed
Jul 20, 2020
| @@ -0,0 +1,47 @@ | |||
| import * as fs from "fs"; | |||
There was a problem hiding this comment.
@fbricon do we need a special header in the new files this PR creates?
Collaborator
Author
|
FYI if you merge #8 first. I can rebase and update the tests to include document selectors as well. |
xorye
reviewed
Jul 20, 2020
Signed-off-by: Ryan Zegray <ryan.zegray@ibm.com>
rzgry
force-pushed
the
test-collect-lsp4mp-extensions
branch
from
455051e to
3e037a7
Compare
xorye
approved these changes
Jul 21, 2020
|
Thanks @rzgry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test for collecting lsp4mp extensions and java version requirements.
Switches mocha interface from
tddtobddso we don't need to importdescribe/itin test files.Also removes the
vscodeTestsdirectory since vscode-microprofile has novscodeUITestsfolder like vscode-quarkus so the extravscodeTestsfolder is not needed.Signed-off-by: Ryan Zegray ryan.zegray@ibm.com