Skip to content

[build] Use Node.js v20 engine as minimum version#4958

Merged
vrubezhny merged 1 commit intoredhat-developer:mainfrom
vrubezhny:fix-bump-node-engine-to-v20
Apr 1, 2025
Merged

[build] Use Node.js v20 engine as minimum version#4958
vrubezhny merged 1 commit intoredhat-developer:mainfrom
vrubezhny:fix-bump-node-engine-to-v20

Conversation

@vrubezhny
Copy link
Copy Markdown
Contributor

The reasons:

  • The mainenance of Node.js v18 (LTS) ends 2025-04-30, so it's time to update the engine
  • A lot of used dependencies declare Node.js v20 as minimum version, it doesn't make sence to continue using v18 as minimum Node.js engine version, f.i.:
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'glob@11.0.1',
npm WARN EBADENGINE   required: { node: '20 || >=22' },
npm WARN EBADENGINE   current: { node: 'v18.17.1', npm: '9.6.7' }
npm WARN EBADENGINE }
...
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'path-scurry@2.0.0',
npm WARN EBADENGINE   required: { node: '20 || >=22' },
npm WARN EBADENGINE   current: { node: 'v18.17.1', npm: '9.6.7' }
npm WARN EBADENGINE }
...
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'lru-cache@11.0.0',
npm WARN EBADENGINE   required: { node: '20 || >=22' },
npm WARN EBADENGINE   current: { node: 'v18.17.1', npm: '9.6.7' }
npm WARN EBADENGINE }

The reasons:
- The mainenance of Node.js v18 (LTS) ends 2025-04-30, so it's time to update the engine
- A lot of used dependencies declare Node.js v20 as minimum version,
it doesn't make sence to continue using v18 as minimum Node.js engine version, f.i.:

```
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'glob@11.0.1',
npm WARN EBADENGINE   required: { node: '20 || >=22' },
npm WARN EBADENGINE   current: { node: 'v18.17.1', npm: '9.6.7' }
npm WARN EBADENGINE }
...
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'path-scurry@2.0.0',
npm WARN EBADENGINE   required: { node: '20 || >=22' },
npm WARN EBADENGINE   current: { node: 'v18.17.1', npm: '9.6.7' }
npm WARN EBADENGINE }
...
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'lru-cache@11.0.0',
npm WARN EBADENGINE   required: { node: '20 || >=22' },
npm WARN EBADENGINE   current: { node: 'v18.17.1', npm: '9.6.7' }
npm WARN EBADENGINE }
```

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.63%. Comparing base (da60441) to head (52cf79f).
Report is 961 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4958       +/-   ##
===========================================
+ Coverage   32.37%   44.63%   +12.25%     
===========================================
  Files          85       99       +14     
  Lines        6505     8129     +1624     
  Branches     1349     1727      +378     
===========================================
+ Hits         2106     3628     +1522     
- Misses       4399     4501      +102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vrubezhny vrubezhny merged commit 9b1cfda into redhat-developer:main Apr 1, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant