Fix broken links in the examples, replace some #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolfedh
approved these changes
Feb 12, 2024
Contributor
rolfedh
left a comment
rolfedh
left a comment
There was a problem hiding this comment.
LGTM - I offered some minor suggestions.
modular-docs-manual/content/topics/module_mod-docs-assembly-examples.adoc
Outdated
Show resolved
Hide resolved
modular-docs-manual/content/topics/module_mod-docs-concept-examples.adoc
Outdated
Show resolved
Hide resolved
…mples.adoc Co-authored-by: Rolfe Dlugy-Hegwer <rolfedh@users.noreply.github.com>
emmurphy1
approved these changes
Feb 13, 2024
neal-timpe
reviewed
Feb 15, 2024
modular-docs-manual/content/topics/module_mod-docs-concept-examples.adoc
Outdated
Show resolved
Hide resolved
neal-timpe
requested changes
Feb 15, 2024
neal-timpe
left a comment
neal-timpe
left a comment
There was a problem hiding this comment.
I left a comment about a 404 in modular-docs-manual/content/topics/module_mod-docs-concept-examples.adoc
Jenny-Anne
approved these changes
Feb 16, 2024
IanFrangs
approved these changes
Feb 16, 2024
Collaborator
IanFrangs
left a comment
IanFrangs
left a comment
There was a problem hiding this comment.
I have tested the URLS of all the added links and they all work for me.
neal-timpe
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #213
Additionally: