Skip to content

Conversation

@mjahoda
Copy link
Contributor

@mjahoda mjahoda commented Feb 12, 2024

Fixes #213

Additionally:

  • fixes some other broken links (404s)
  • replaces some not so good examples that included self-referential texts (for example)
  • changes html-single to html-multi in module examples

@mjahoda mjahoda requested a review from a team as a code owner February 12, 2024 10:24
Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I offered some minor suggestions.

mjahoda and others added 2 commits February 12, 2024 21:06
…mples.adoc

Co-authored-by: Rolfe Dlugy-Hegwer <rolfedh@users.noreply.github.com>
Copy link

@neal-timpe neal-timpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment about a 404 in modular-docs-manual/content/topics/module_mod-docs-concept-examples.adoc

@mjahoda mjahoda self-assigned this Feb 16, 2024
@mjahoda mjahoda requested a review from neal-timpe February 16, 2024 08:32
Copy link
Collaborator

@IanFrangs IanFrangs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the URLS of all the added links and they all work for me.

@mjahoda mjahoda merged commit 1848b01 into redhat-documentation:main Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error 404 for a reference module example

6 participants