Skip to content

Conversation

@gaurav-nelson
Copy link
Contributor

This pull request updates the GitHub Actions workflow for deploying the site by upgrading several GitHub Actions to their latest major versions. These updates help ensure continued support, security, and access to the latest features.

Workflow dependency upgrades:

  • Updated actions/checkout from version 3 to version 5 in .github/workflows/deploy-site.yml.
  • Updated actions/configure-pages from version 3 to version 5 in .github/workflows/deploy-site.yml.
  • Updated actions/upload-pages-artifact from version 1 to version 4 in .github/workflows/deploy-site.yml.
  • Updated actions/deploy-pages from version 2 to version 4 in .github/workflows/deploy-site.yml.

Fixes #246

@gaurav-nelson gaurav-nelson requested a review from a team as a code owner October 28, 2025 02:06
@mjahoda
Copy link
Contributor

mjahoda commented Oct 28, 2025

Hi Gaurav. Thank you for the PR. I submitted the fix in #244 some time ago. Unfortunately, the PR hasn't received the required amount of approvals yet. I'll approve yours because with my +1, there's a bigger chance to reach the threshold.

Copy link
Collaborator

@abhatt-rh abhatt-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaurav-nelson
Copy link
Contributor Author

Thank you @mjahoda @abhatt-rh

At least 3 approving reviews are required to merge this pull request.

These rules are more stricter than production docs we do.

I'll wait for approvals :)

@abhatt-rh
Copy link
Collaborator

You make a good point, @gaurav-nelson !
FWIW, I relaxed it from 4 to 3 approvals yesterday but now I'm wondering if we should just narrow it down to 2 😅

Thank you @mjahoda @abhatt-rh

At least 3 approving reviews are required to merge this pull request.

These rules are more stricter than production docs we do.

I'll wait for approvals :)

@abhatt-rh abhatt-rh merged commit cb320f1 into redhat-documentation:main Nov 4, 2025
@mjahoda mjahoda mentioned this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Site build is broken

3 participants