Allow multiple kustomization paths#659
Merged
oglok merged 1 commit intoopenshift:mainfrom Apr 21, 2022
Merged
Conversation
mangelajo
force-pushed
the
multiple-manifests
branch
3 times, most recently
from
0cf97bb to
c926dea
Compare
Contributor
Author
|
/test |
Contributor
|
@mangelajo: The
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This extends the single path /var/lib/microshift/manifests default into: - /usr/lib/microshift/manifests - /etc/microshift/manifests - /var/lib/microshift/manifests which will be evaluated in order. While the first one could be fully managed in ostree (core components), the second one could be managed by configuration management, the third one is maintained for backwards compatibility purposes. In addition the MicroShift configuration file supports customization of this via the manifestsDir entry.
mangelajo
force-pushed
the
multiple-manifests
branch
from
c926dea to
241994b
Compare
Contributor
Author
|
/retest |
Contributor
Author
Contributor
|
Thanks for the PR! I think we should test a specific config.yaml pointing at a set of manifests. Code wise looks good. |
Contributor
Author
|
Contributor
Author
|
It seems to work as expected :-) |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oglok The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
mangelajo
added a commit
to mangelajo/microshift-documentation
that referenced
this pull request
May 6, 2022
This commit documents the behaviour implemented in openshift/microshift#659
copejon
pushed a commit
to microshift-io/microshift-documentation
that referenced
this pull request
May 6, 2022
This commit documents the behaviour implemented in openshift/microshift#659
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extends the single path /var/lib/microshift/manifests
default into:
which will be evaluated in order. While the first one could be fully
managed in ostree (core components), the second one could be managed
by configuration management, the third one is maintained for backwards
compatibility purposes.
In addition the MicroShift configuration file supports customization
of this via the manifestsDir entry.