Support manifest embedding in user-app rpms & fixes#670
Support manifest embedding in user-app rpms & fixes#670fzdarsky merged 2 commits intoopenshift:mainfrom
Conversation
This commit adds support for embedding application manifests into the user-application containers for use with microshift/ostree
mangelajo
force-pushed
the
paack-manifests
branch
from
2f12a8f to
830fb0e
Compare
First, rpm requires the file attribute uid/gid to be symbolic and not numeric. Additionally tar didn't store the caps but cpio doesn't keep those inside rpm either. So we create a list of file caps during tar creation, and then we populate the %files metadata with %caps attributes so those are re-installed during rpm unpack. This is tested and working.
mangelajo
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fzdarsky The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@mangelajo: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
2 participants
First commit adds support for embedding application manifests
into the user-application containers for use with microshift/ostree
Second commit fixes uid/gid setup and file capabilities
rpm requires the file attribute uid/gid to be symbolic
and not numeric. Additionally tar didn't store the caps
but cpio doesn't keep those inside rpm either.
So we create a list of file caps during tar creation, and then
we populate the %files metadata with %caps attributes so those
are re-installed during rpm unpack.
This is tested and working.