Conversation
There was a problem hiding this comment.
Similar theme to a prior comment I just added: somewhere above I believe we will need to pass in map_params("local_bind_addr") which is the address nova services will bind to. So, the quickstack::nova class would need to be edited to add param(s) for that. It is open to debate whether to add one param for nova service, or just one shared param.
There was a problem hiding this comment.
Good catch, totally forgot that, thanks
|
Once commits are squashed, +1 to merge. Tested with "nova flavor-list" on all nodes and openstack-status (all openstack-nova* services running (4 of 'em) except for openstack-nova-compute and openstack-nova-network). One minor point -- and I do not think it is worth iterating over at this point even if we decide to change it -- which is I'm not sure we really need the three ip params: loadbalancer_public_vip, loadbalancer_private_vip, loadbalancer_admin_vip. vs. just one for loadbalancer. This vip will mainly be useful for adminstrative / ha stat reasons, right? (Of course, right now we could set them all to the same value, so the user is not forced to pick three separate IP's). |
https://bugzilla.redhat.com/show_bug.cgi?id=1075818 - Use new VIP define - Move params to params.pp - add backend block to quickstack::load_balancer
2 participants
Not yet tested, looking for sanity check only for now