Skip to content

contain pcmk_resource within the quickstack pacemaker service#396

Merged
jguiditta merged 1 commit intoredhat-openstack:icehouse_stablefrom
cwolferh:pcmk_resource_service_containment
Oct 27, 2014
Merged

contain pcmk_resource within the quickstack pacemaker service#396
jguiditta merged 1 commit intoredhat-openstack:icehouse_stablefrom
cwolferh:pcmk_resource_service_containment

Conversation

@cwolferh
Copy link

This PR it intended to address the error http://fpaste.org/145063/14200364/ discovered by QE . I was not able to reproduce this error in development, despite re-running puppet and deleting pcs resources a couple of dozen times. However, this PR takes a stab at fixing the potential problems:

  • a non-deterministic puppet error where the actual bit of puppet that creates the pacemaker resource wasn't "contained" (by adding the anchors and " -> Pcmk_Resource["$name"]")
  • making sure pacemaker has really created resource (it may take some time for the cluster nodes to agree it has been created) with an extra exec/wait check.

I tested it, seems to work.

@cwolferh cwolferh force-pushed the pcmk_resource_service_containment branch 3 times, most recently from ebc0860 to 96aa6e7 Compare October 27, 2014 04:35
https://bugzilla.redhat.com/show_bug.cgi?id=1157340

Make sure dependent pacemaker services are really created within
quickstack::pacemaker::resource::service (so that other puppet
manifests may make the assumption the pacemaker resource exists after
a declaration of quickstack::pacemaker::resource::service).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very clever

jguiditta added a commit that referenced this pull request Oct 27, 2014
contain pcmk_resource within the quickstack pacemaker service
@jguiditta jguiditta merged commit 2c35157 into redhat-openstack:icehouse_stable Oct 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants