Remove node's contraints#298
Merged
lebauce merged 1 commit intoredhat-openstack:masterfrom Nov 17, 2016
Merged
Conversation
Any cotnraint causes that heat does an external API call when validating the stack (on any update/create operation). This is a big problem for large deployments, e.g. 6 contraints took ~6 seconds per single node -> with 50 nodes it took 5 mins to only validate because validation is sequential. These params are validated in the top-level openshift.yaml templates so it's safe to remove them to speed things up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any cotnraint causes that heat does an external API call when
validating the stack (on any update/create operation). This is a big
problem for large deployments, e.g. 6 contraints took ~6 seconds
per single node -> with 50 nodes it took 5 mins to only validate because
validation is sequential.
These params are validated in the top-level openshift.yaml templates
so it's safe to remove them to speed things up.