Wait for all nodes being added before running ansible#302
Merged
tomassedovic merged 2 commits intoredhat-openstack:masterfrom Apr 7, 2017
Merged
Wait for all nodes being added before running ansible#302tomassedovic merged 2 commits intoredhat-openstack:masterfrom
tomassedovic merged 2 commits intoredhat-openstack:masterfrom
Conversation
Contributor
Author
|
Please do not merge into a branch for GA release (this is not a blocker, I would prefer to have this merged in a next release) |
Contributor
|
@jprovaznik We'd like to test and merge this now but it requires a rebase. If you can do that quickly we can get it merged. |
Openshift compute ndoes are members of AutoscalingGroup in heat
stack, when each member is created it registers itself on
bastion node ("deployment_bastion_node_add" SW deployment in
templates), then a separate step ("deployment_run_ansible"
in node.yaml) configures openshift on all nodes which are
already registered.
It may happen that deployment_run_ansible is trigerred by
some node before all nodes are registered (by deployment_bastion_node_add)
which causes that then nodes are added in multiple ansible
runs/batches. It doesn't break setup and basically is
nothing bad with it but it makes creation or scale up
slower. It would be better to wait until deployment_bastion_node_add
is done for all nodes and then run deployment_run_ansible
only once for all nodes (AutoscalingGroup doesn't allow to do this easily though).
This patch uses node_count param to get desired number of nodes,
this can not work with autoscaling though so it's used only for
not-autoscaling create/update scenario.
Contributor
Author
|
@markllama I've rebased the patch, but please pay extra attention to assure it still works - I did just rebase of the patch, no teesting. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Openshift compute ndoes are members of AutoscalingGroup in heat
stack, when each member is created it registers itself on
bastion node ("deployment_bastion_node_add" SW deployment in
templates), then a separate step ("deployment_run_ansible"
in node.yaml) configures openshift on all nodes which are
already registered.
It may happen that deployment_run_ansible is trigerred by
some node before all nodes are registered (by deployment_bastion_node_add)
which causes that then nodes are added in multiple ansible
runs/batches. It doesn't break setup and basically is
nothing bad with it but it makes creation or scale up
slower. It would be better to wait until deployment_bastion_node_add
is done for all nodes and then run deployment_run_ansible
only once for all nodes (AutoscalingGroup doesn't allow to do this easily though).
This patch uses node_count param to get desired number of nodes,
this can not work with autoscaling though so it's used only for
not-autoscaling create/update scenario.