add os_domain_name #335 #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Is there a reference that shows that openshift-ansible will accept this new parameter? |
Contributor
Author
|
@markllama I found the following. Let me know if it's ok or if I should reformat something. Thx++Peace, Added in |
Contributor
Author
|
Only set os_domain_name when using v2 now. |
ioggstream
force-pushed
the
335-add-os_domain_name
branch
from
6489377 to
1ebc495
Compare
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for v3 endpoint and os_domain_name in openstack configuration.
This works smoothly on my RHOSP9 + OCP 3.4