Conversation
|
This relates to RPOPC-888 |
frival
added
the
group_review_lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provides proper path to detect_numa
Before/After Comparison
Before: Failure with message
./run_stream: line 236: /home/ec2-user/test_tools/detect_numa: No such file or directory
(standard_in) 2: syntax error
(standard_in) 1: syntax error
./run_stream: line 314: /home/ec2-user/test_tools//detect_numa: No such file or directory
libgomp: Invalid value for environment variable OMP_NUM_THREADS:
After: Ran successfully and produce results as expected.
Clerical Stuff
This closes #66
Relates to JIRA: RPOPC-888
Testing
Ran streams on test system
Before change, we failed on detect_numa
After change, we produced the expected results
csv file
Array_sizes,36608k,73216k,146432k,292864k,Start_Date,End_Date
Copy,77813,80257,80115,79999,2026-03-19T14:07:14Z,2026-03-19T14:15:58Z
Scale,63074,62899,62624,62493,2026-03-19T14:07:14Z,2026-03-19T14:15:58Z
Add,71302,70123,69988,69861,2026-03-19T14:07:14Z,2026-03-19T14:15:58Z
Triad,70991,70483,70076,69959,2026-03-19T14:07:14Z,2026-03-19T14:15:58Z