-
Notifications
You must be signed in to change notification settings - Fork 2
🐛 Adding empty dir, to avoid failures #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning Rate limit exceeded@cardil has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 46 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe pull request modifies the GitHub Actions workflow file Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/pr-close.yml (1)
19-19: Remove trailing whitespaceThere is unnecessary trailing whitespace on this line.
- +🧰 Tools
🪛 yamllint (1.35.1)
[error] 19-19: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/pr-close.yml(1 hunks)
🧰 Additional context used
📓 Learnings (2)
📓 Common learnings
Learnt from: cardil
PR: cardil/solution-pattern-event-mesh-for-microservices#2
File: .github/workflows/pr-close.yml:0-0
Timestamp: 2024-12-18T18:30:51.465Z
Learning: In `.github/workflows/pr-close.yml`, the “Make empty dir” step is required to ensure the directory exists before the `github-pages-deploy-action` can remove it. Removing this step causes a “directory doesn't exist” error during cleanup.
.github/workflows/pr-close.yml (1)
Learnt from: cardil
PR: cardil/solution-pattern-event-mesh-for-microservices#2
File: .github/workflows/pr-close.yml:0-0
Timestamp: 2024-12-18T18:30:51.465Z
Learning: In `.github/workflows/pr-close.yml`, the “Make empty dir” step is required to ensure the directory exists before the `github-pages-deploy-action` can remove it. Removing this step causes a “directory doesn't exist” error during cleanup.
🪛 yamllint (1.35.1)
.github/workflows/pr-close.yml
[error] 19-19: trailing spaces
(trailing-spaces)
🔇 Additional comments (1)
.github/workflows/pr-close.yml (1)
17-18: LGTM! Essential fix for directory handling
This step is crucial as it ensures the target directory exists before the github-pages-deploy-action attempts to remove it, preventing the "directory doesn't exist" error that was occurring previously.
|
A preview of d7c7695 is uploaded and can be seen here: ✨ https://cardil.github.io/solution-pattern-event-mesh-for-microservices/pull-3 ✨ Changes may take a few minutes to propagate. The source is here: https://github.com/cardil/solution-pattern-event-mesh-for-microservices/tree/gh-pages/pull-3 |
68da8d1 to
d7c7695
Compare
See: #2 (comment)
Summary by CodeRabbit