Fix: Eliminate vm2 security vulnerability#358
Merged
Conversation
Update proxy-agent from 6.2.1 to 6.5.0 to remove the deprecated and vulnerable vm2 package from the dependency tree. The newer version uses @tootallnate/quickjs-emscripten as a safe alternative for JavaScript sandboxing. This eliminates multiple critical CVEs (CVSS 9.8-10.0): - CVE-2023-29017, CVE-2023-30547, CVE-2023-37466 - CVE-2023-37903, CVE-2022-36067 All tests pass with no breaking changes. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Updated actions/checkout and actions/setup-node from v2 to v4 to resolve persistent yarn cache service errors (400 responses) in CI. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security Impact
This update removes all `vm2` dependencies, eliminating multiple critical CVEs:
Dependency Chain Changes
Before (v6.2.1)
```⚠️ DEPRECATED & VULNERABLE
proxy-agent@6.2.1
└─> pac-proxy-agent@6.0.3
└─> pac-resolver@6.0.1
└─> degenerator@4.0.2
└─> vm2@3.9.17
```
After (v6.5.0)
```
proxy-agent@6.5.0
└─> pac-proxy-agent@7.2.0
└─> pac-resolver@7.0.1
└─> degenerator@5.0.1
└─> @tootallnate/quickjs-emscripten@0.23.0 ✅ SAFE
```
Changes Made
Test Plan
Additional Context
The `vm2` package has been officially deprecated with the warning: "The library contains critical security issues and should not be used for production! The maintenance of the project has been discontinued."
This fix resolves compliance issues for all spandx users, even though spandx is typically used as a devDependency, as the vulnerability can be flagged by security scanners in production containers.
🤖 Generated with [Claude Code](https://claude.com/claude-code\)