Fix lowercase GitHub-style alerts #360
Merged
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub-style alerts in Markdown are case-insensitive. For example, an inline warning in the style of > [!warning] > Body of the warning is supported on GitHub. While Otterwiki detects this as a warning, the `[!warning]` command is not removed from the rendering of the box, because one regex was not case-insensitive. This commit fixes this bug and adds a test that checks whether the command was removed from the rendering.
Owner
|
Looks good to me, thank you @aimileus! |
Owner
|
Released in v2.17.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub-style alerts in Markdown are case-insensitive. For example, an inline warning in the style of
GitHub rendering:
Warning
Body of the warning
is supported on GitHub. While Otterwiki detects this as a warning, the
[!warning]command is not removed from the rendering of the box, because one regex was not case-insensitive.Current Otterwiki rendering:
This PR fixes this bug and adds a test that checks whether the command was removed from the rendering.