fix(checkpoint): ashallow missing TTL expire for checkpoint_writes #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hello @bsbodden @abrookins , sorry to bother you before new years but this is quite critical, if you will find time I will appreciate it |
Contributor
I'm on it! |
Contributor
|
@demetere can you run |
bsbodden
requested changes
Jan 2, 2026
Contributor
bsbodden
left a comment
bsbodden
left a comment
There was a problem hiding this comment.
LGTM, just run format and lint and we'll merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #137
AsyncShallowRedisSaverwas missing an expiration forcheckpoint_writekeys, which caused memory leaks.This issue is critical, as it affects production environments. The PR adds the missing expiration logic and includes test cases to cover the fix.
Tests
I ran
make test-alland passed all of the tests including new ones