Skip to content

Conversation

@justin-cechmanek
Copy link
Contributor

No description provided.

@tylerhutcherson
Copy link
Collaborator

Realizing this actually depends on the upcoming release of redisvl. So we can hold it in a PR and merge / test once the package is available (no big deal). Make sure to update the README and colab links since you changed notebook name (which I agree with).

Also is it always practical to inflate your integers using a scaled method before casting to int8? Aren't there models from hugging face or cohere we can showcase here for int8?

@justin-cechmanek
Copy link
Contributor Author

There some non-scaled huggingface models, but the first I found still have typical values between (-5.0, +5) so using those raw still has a lot of rounding error when cast to int.

@justin-cechmanek
Copy link
Contributor Author

In our test environment we're using the docker image redis-stack-server:latest, which still is on Redis 7.4. @tylerhutcherson we can update the test env, or wait until the latest docker image uses Redis 8.0 for int8 support. Thoughts?

@tylerhutcherson
Copy link
Collaborator

@justin-cechmanek let's update the CI to use the redis:8.0-M03 docker image. Good catch. Assuming that fixes the issue here, let's try to get that updated and we can merge. Tag me whenever ready!

@justin-cechmanek justin-cechmanek marked this pull request as ready for review March 7, 2025 23:02
@tylerhutcherson tylerhutcherson added the enhancement New feature or request label Mar 8, 2025
@tylerhutcherson tylerhutcherson changed the title renames notebook and includes integer vector datatype example Vector dtype recipe update for int8 Mar 8, 2025
@tylerhutcherson tylerhutcherson merged commit 53776ca into main Mar 8, 2025
2 checks passed
@tylerhutcherson tylerhutcherson deleted the feat/RAAE-643/update-vector-dtypes-notebook branch March 8, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants