feat(cloud): add --wait flag support for connectivity commands #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add AsyncOperationArgs to VPC Peering commands (6 commands) - Add AsyncOperationArgs to PSC commands (9 commands) - Add AsyncOperationArgs to TGW commands (7 commands) - Update VPC Peering handlers to use handle_async_response - Update match arms for PSC and TGW to include async_ops parameter - Add async_utils import to connectivity modules Note: This is a work in progress. Function signatures need updating for PSC and TGW handler implementations. Part of #196
…mands - Updated all PSC handler functions to use handle_async_response - Updated all VPC Peering handlers (already done in previous commit) - Updated TGW handler function signatures to accept ConnectionManager - Replaced manual task ID handling with handle_async_response utility - All connectivity commands now support --wait, --wait-timeout, and --wait-interval flags Completes implementation for: - VPC Peering: 6 commands (create, update, delete + Active-Active variants) - PSC: 9 commands (service and endpoint operations + Active-Active variants) - TGW: 7 commands (attachment operations + Active-Active variants) Part of #196 Closes #196
- Add ConnectivityOperationParams struct to group common parameters - Refactor all VPC Peering, PSC, and TGW functions to use the new struct - Update all function call sites to use the parameter struct - Remove unused AsyncOperationArgs imports - Reduces function parameters from 8-10 down to 2-4 arguments
This was referenced Sep 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the
--waitflag to Cloud connectivity commands (VPC Peering, PSC, TGW), allowing users to wait for async network operations to complete. Network operations can take 5-15 minutes, so this feature provides progress indicators and automatic polling.Changes
handle_async_responseutilityhandle_async_responseutilityhandle_async_responseutilityConnectivityOperationParamsstruct to address clippy too_many_arguments warningsStatus
✅ Complete - All connectivity commands now support the
--waitflag with proper async operation handling.Commands Updated
VPC Peering (✅ Complete)
redisctl cloud connectivity vpc-peering create --waitredisctl cloud connectivity vpc-peering update --waitredisctl cloud connectivity vpc-peering delete --waitredisctl cloud connectivity vpc-peering create-aa --waitredisctl cloud connectivity vpc-peering update-aa --waitredisctl cloud connectivity vpc-peering delete-aa --waitPSC (✅ Complete)
redisctl cloud connectivity psc service-create --waitredisctl cloud connectivity psc service-delete --waitredisctl cloud connectivity psc endpoint-create --waitredisctl cloud connectivity psc endpoint-update --waitredisctl cloud connectivity psc endpoint-delete --waitTGW (✅ Complete)
redisctl cloud connectivity tgw attachment-create --waitredisctl cloud connectivity tgw attachment-update --waitredisctl cloud connectivity tgw attachment-delete --waitCode Quality Improvements
ConnectivityOperationParamsstruct to group common parametersTesting
Related Issues
Closes #196 (connectivity commands)
Part of #175 (overall --wait flag implementation)