feat(redisctl): add --wait flag support for Cloud ACL commands #201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for the
--waitflag to all Cloud ACL operations, allowing users to wait for async operations to complete.Changes
ACL Redis Rules (3 commands)
cloud acl create-redis-rule- Creating ACL rulescloud acl update-redis-rule- Updating ACL rulescloud acl delete-redis-rule- Deleting ACL rulesACL Roles (3 commands)
cloud acl create-role- Creating ACL rolescloud acl update-role- Updating ACL rolescloud acl delete-role- Deleting ACL rolesACL Users (3 commands)
cloud acl create-acl-user- Creating ACL userscloud acl update-acl-user- Updating ACL userscloud acl delete-acl-user- Deleting ACL usersImplementation Details
AsyncOperationArgsto all 9 ACL command variants inCloudAclCommandsenumhandle_async_responsefor consistent async operation handlingAclOperationParamsstruct to group common parameters and avoid clippy's too_many_arguments warning--forceand--waitflagsTesting
Example Usage
Related Issues
Fixes #194
Part of #175 (Cloud async operations support)
Backwards Compatibility
The changes maintain full backward compatibility - if the wait flags are not specified, operations behave synchronously as before.