refactor: fold redis-common into redisctl and fix docs.rs #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move redis-common modules (config, error, output) into redisctl/src - Update all imports from redis_common:: to crate:: - Add lib.rs to redisctl with documentation for docs.rs - Mark redis-common as publish=false since it's internal only - Remove redis-common from workspace members - Add dependencies from redis-common to redisctl Cargo.toml This fixes the docs.rs issue where redisctl showed "not a library" and simplifies the workspace structure since redis-common was only used by the CLI, not the library crates.
joshrotenberg
force-pushed
the
fix/redisctl-docs
branch
from
4143f0b to
92beffd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
redis_common::tocrate::publish=false(and later will be removed entirely)Motivation
The redis-common crate was only used by redisctl, not by the library crates (redis-cloud and redis-enterprise). Since it's an internal utility crate with no standalone value, it makes more sense to have these modules directly in redisctl. This also fixes the docs.rs issue where redisctl wasn't showing documentation because it was a binary-only crate.
Testing
Closes #21