feat(enterprise): add module management commands #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add module list, get, upload, delete, and config-bdb commands - Fix Module struct to match actual API response (module_name instead of name, version as u32) - Remove upgrade-bdb command as endpoint doesn't exist in API - Update tests to match new field names - Document correct config-bdb format in CLAUDE.md Note: upload command needs multipart/form-data implementation Implements #153
- Add multipart/form-data support to reqwest client - Implement module upload using v2 endpoint with v1 fallback - Add proper error handling for missing upload endpoints - Update tests to handle v2/v1 fallback behavior - Document v1 vs v2 API strategy in CLAUDE.md - Note that module upload may not be available on all instances The upload command now properly handles multipart uploads and gracefully falls back from v2 to v1 when needed.
The doc test incorrectly referenced v1() and v2() methods that don't exist. ModuleHandler methods are called directly, with upload() handling v2/v1 fallback internally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements module management commands for Redis Enterprise (#153).
Changes
namefield tomodule_nameversionfrom String to u32Testing
All commands tested against local Redis Enterprise instance:
module list- works correctly, lists all available modulesmodule get <uid>- works correctly, retrieves specific module detailsmodule config-bdb- works with correct format:{"modules": [{"module_name": "search", "module_args": "PARTITIONS AUTO"}]}module delete- works correctly with force flagmodule upload- needs multipart/form-data implementation (tracked separately)Notes
Closes #153