fix: release workflow tag pattern to enable binary builds #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 'toolchain: stable' to dtolnay/rust-toolchain action - Remove continue-on-error from cargo-deny since deny.toml is configured - Fixes workflow parsing error that caused immediate failure
- Change pattern from '**[0-9]+.[0-9]+.[0-9]+*' to '**v[0-9]+.[0-9]+.[0-9]+*' - This matches tags like redisctl-v0.1.1 created by release-plz - Fixes missing binary artifacts on releases
- Change workflow name from 'Release' to 'Release Binaries' - Makes it clearer in GitHub Actions UI what this workflow does
- Initialize cargo-dist properly with dist-workspace.toml - Set tag-namespace to 'redisctl' to match release-plz tags - Generated workflow now triggers on 'redisctl**[0-9]+.[0-9]+.[0-9]+*' - Removed old release.yml, using redisctl-release.yml instead - This will enable binary builds for tags like redisctl-v0.1.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Binary artifacts are not being created for releases. The v0.1.1 release has no binaries attached.
Root Cause
0.1.0but release-plz creates tags likeredisctl-v0.1.1Solution
Properly configured cargo-dist with:
dist-workspace.tomlwithtag-namespace = "redisctl"redisctl**[0-9]+.[0-9]+.[0-9]+*redisctl-release.yml(namespace-prefixed)Changes
dist-workspace.tomlconfiguration fileredisctl-release.ymlworkflowrelease.ymlworkflowTesting
Once merged, the workflow will trigger automatically for:
redisctl-v0.1.1can be re-pushed to build binariesImpact
All future releases will automatically build and attach binary artifacts for: