refactor: simplify Docker setup with public images #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace private kurtfm image with official redislabs/redis image - Simplify docker-compose.yml to essential services only - Remove Makefile in favor of direct docker-compose commands - Update Dockerfile to build unified redisctl binary with Rust 1.89 - Remove CLAUDE.md and add to .gitignore - Update README with simplified Docker instructions
- Focus on essential use case: cluster init + database creation - Use workflow commands for initialization - Add helpful output showing connection details - Simplify to just two services: enterprise and init
- Add cascading Docker Compose test (cluster init -> db create -> API validation -> Redis test) - Add Docker test workflow for CI - Simplify Dockerfile to use Debian bookworm-slim for compatibility - Remove private image requirement, default to official Redis Enterprise image
Cargo.lock is gitignored so it's not available in CI builds
Rust 1.89 builds require GLIBC 2.39 which is not available in Debian bookworm
Let useradd pick the next available UID to prevent 'UID 1000 is not unique' error in Ubuntu 24.04
The Dockerfile sets ENTRYPOINT to redisctl, so we need to override it to use shell for our test scripts
The entrypoint is already set to ['/bin/sh', '-c'], so we don't need sh -c in the command string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
kurtfm/rs-armimage with officialredislabs/redis:latestredisctlbinary with Rust 1.89Testing
--profile cliflag