fix: add workflow_dispatch trigger to crates publish workflow #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release:published event doesn't fire when GitHub releases are created by other actions (using GITHUB_TOKEN), which prevents automatic crates.io publishing. Adding workflow_dispatch allows manual triggering as a fallback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The crates.io publish workflow didn't trigger for the v0.5.0 release.
Root Cause
When GitHub Actions creates a release using GITHUB_TOKEN (which cargo-dist does), it doesn't trigger other workflows'
release:publishedevents to prevent infinite loops. This is documented GitHub behavior.Solution
Add
workflow_dispatchas an additional trigger to allow manual publishing when the automatic trigger doesn't fire.Changes
workflow_dispatchtrigger to publish-crates.ymlTesting
After merging, we can manually trigger the workflow to publish v0.5.0 to crates.io.