fix(enterprise): fix deserialization errors in cluster, user, and license structs #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workflow commands are not yet implemented in the CLI (they're commented out). Updated docker-compose.yml to remove the auto-init container and added manual initialization instructions instead.
The workflow init-cluster command IS implemented and working. The issue was using :latest tag which might not have the latest code. Using explicit v0.5.0 tag ensures the workflow command is available.
- Bootstrap API doesn't require authentication initially - Modified init-cluster workflow to create unauthenticated client for bootstrap - Added ARM64 Redis Enterprise image requirement to CLAUDE.md - Fixed docker-compose.yml to build from local Dockerfile for testing - Verified workflow successfully initializes cluster with admin user and database
The init-cluster workflow fix for unauthenticated bootstrap is not in v0.5.0, so the docker-compose workflow won't work until the next release. Commented out the init container with instructions for manual initialization and notes to re-enable after v0.5.1 is published.
…ense structs - Fix ClusterInfo struct field types to match actual API responses: - sentinel_cipher_suites: String -> Vec<String> - sentinel_cipher_suites_tls_1_3: Vec<Value> -> String - password_complexity: Value -> bool - mtls_certificate_authentication: String -> bool - upgrade_mode: String -> bool - Fix User struct to match actual API: - Remove non-existent 'username' field - Make 'email' required (it's the user identifier) - Add 'name' field for display name - Add missing fields: auth_method, certificate_subject_line, role_uids - Fix License struct: - Remove required 'license_key' field (doesn't exist) - Keep 'key' and 'license' as optional fields - Update mock tests to use realistic API responses - Add comprehensive cluster info test with actual API data - Fix rbac_impl.rs to use email instead of username Fixes #316, #317, #323, #324, #325
This was referenced Sep 15, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes multiple deserialization errors that were preventing enterprise commands from working correctly. The issues were caused by mismatches between our struct definitions and the actual API responses.
Problem
Several enterprise commands were failing with "error decoding response body" errors because the struct field types didn't match what the API actually returns.
Changes
ClusterInfo Struct Fixes
sentinel_cipher_suites: Changed fromOption<String>toOption<Vec<String>>(API returns array)sentinel_cipher_suites_tls_1_3: Changed fromOption<Vec<Value>>toOption<String>(API returns string)password_complexity: Changed fromOption<Value>toOption<bool>(API returns boolean)mtls_certificate_authentication: Changed fromOption<String>toOption<bool>(API returns boolean)upgrade_mode: Changed fromOption<String>toOption<bool>(API returns boolean)User Struct Fixes
usernamefieldemailfromOption<String>toString(it's the user identifier)namefield for display nameauth_method,certificate_subject_line,role_uidsLicense Struct Fixes
license_keyfield (doesn't exist in API)keyandlicenseas optional fields as returned by APITest Updates
Testing
cargo test --package redis-enterpriseenterprise cluster get✓enterprise user list✓enterprise cluster get-license✓Fixes
Related Issues