fix(redis-enterprise): remove non-existent database action methods #443
+13
−141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes three database action methods from crate that call non-existent API endpoints.
Problem
The library contained three methods that always fail with 404:
BdbHandler::start()- calls/v1/bdbs/{uid}/actions/startBdbHandler::stop()- calls/v1/bdbs/{uid}/actions/stopBdbHandler::restart()- calls/v1/bdbs/{uid}/actions/restartVerification
Docker Cluster Testing:
Documentation Search:
Comprehensive search of redis.io REST API documentation confirms these endpoints do not exist. The complete list of documented database action endpoints is:
stop_traffic/resume_traffic(NOT the same as stop/start)export/import/recoveroptimize_shards_placement/rebalancebackup_reset_status/import_reset_status/export_reset_statusSearch results: https://redis.io/docs/latest/operate/rs/references/rest-api/requests/bdbs/actions/
Changes
Removed Methods:
crates/redis-enterprise/src/bdb.rs- Removedstart(),stop(),restart()methodsRemoved Tests:
crates/redis-enterprise/tests/database_tests.rs- Removedtest_database_start,test_database_stopcrates/redis-enterprise/src/lib_tests.rs- Removedtest_database_action_start,test_database_action_stopDocumentation Updates:
docs/src/enterprise/examples.md- Changed "Rolling Restart" example to usestop_traffic/resume_trafficdocs/src/enterprise/api-access.md- Updated action list to show actual endpointsTesting
Related Issues
Closes #421 - Database restart command cannot be implemented as the API doesn't support it
Notes
While
rladmin restart dbexists as a CLI command, it uses internal mechanisms not exposed via the REST API. Users needing to pause traffic should usestop_traffic+resume_trafficinstead, though this doesn't achieve the same effect as restarting the database process.