fix: remove complex SARIF generation from security workflow #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshrotenberg
force-pushed
the
fix/security-workflow-yaml
branch
from
9b7399d to
3ba67eb
Compare
joshrotenberg
changed the title
joshrotenberg
force-pushed
the
fix/security-workflow-yaml
branch
from
3ba67eb to
72251cd
Compare
- Updates Rust version to 1.89 to support edition 2024 - Updates cargo-audit to 0.21.2 (0.20.5 doesn't exist) - Removes complex Python script for SARIF generation - Keeps simple cargo audit check which is sufficient
joshrotenberg
force-pushed
the
fix/security-workflow-yaml
branch
from
72251cd to
0d01e13
Compare
- Removed dependency-review job as it requires GitHub Advanced Security - Added Rust 1.89 toolchain installation for cargo-deny to support edition 2024
cargo-deny doesn't support Rust edition 2024 yet. Since cargo-audit already provides security vulnerability checking, we can safely remove cargo-deny for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Security Workflow
Fixes two issues in the security workflow:
Problems Fixed
1. Edition 2024 Support
stabletoolchain (1.80.0) which doesn't support edition 20242. Complex SARIF Generation
Solution
cargo audit --deny warningsBenefits
Fixes: https://github.com/joshrotenberg/redisctl/actions/runs/17313085658