Skip to content

Conversation

@joshrotenberg
Copy link
Collaborator

Summary

Switches Docker image hosting from Docker Hub to GitHub Container Registry (GHCR).

Changes

Workflow (.github/workflows/docker.yml)

  • Remove Docker Hub login step
  • Remove Docker Hub README sync step
  • Update registry to ghcr.io
  • Simplified tags to GHCR only

Documentation

  • Update all docker run examples to use ghcr.io/redis-developer/redisctl
  • Update docker-compose.yml image references
  • Update RELEASE.md checklist

Benefits

  • No Docker Hub account/secrets needed
  • Auth handled via built-in GITHUB_TOKEN
  • Simpler CI configuration
  • Images stored alongside code

New Image Location

docker pull ghcr.io/redis-developer/redisctl:latest
docker run --rm ghcr.io/redis-developer/redisctl --help

Testing

  • cargo fmt - pass
  • cargo clippy - pass

- Remove Docker Hub login and push from workflow
- Remove Docker Hub README sync step
- Update all documentation to use ghcr.io/redis-developer/redisctl
- Update docker-compose.yml image references
- Simplifies CI by removing DOCKERHUB_USERNAME/TOKEN secrets requirement
@joshrotenberg joshrotenberg merged commit 7312361 into main Dec 16, 2025
16 of 17 checks passed
@joshrotenberg joshrotenberg deleted the chore/ghcr-only branch December 16, 2025 19:53
This was referenced Dec 16, 2025
joshrotenberg added a commit that referenced this pull request Dec 16, 2025
PR #500 accidentally corrupted GitHub repository URLs by adding
`ghcr.io/` to them (e.g., `github.com/ghcr.io/redis-developer/redisctl`).
The `ghcr.io/` prefix is only valid for Docker image references, not
GitHub repository URLs.

This PR fixes:
- GitHub repository URLs (remove errant `ghcr.io/`)
- Homebrew tap references (`joshrotenberg/brew` → `redis-developer/homebrew-tap`)
- Documentation URLs (`joshrotenberg.github.io` → `redis-developer.github.io`)
- GHCR link in RELEASE.md checklist

Files updated:
- README.md
- RELEASE.md
- docs/src/getting-started/installation.md
- docs/src/introduction.md
- docs/src/presentation/slides.html

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
joshrotenberg added a commit that referenced this pull request Dec 16, 2025
PR #500 accidentally corrupted GitHub repository URLs by adding
`ghcr.io/` to them (e.g., `github.com/ghcr.io/redis-developer/redisctl`).
The `ghcr.io/` prefix is only valid for Docker image references, not
GitHub repository URLs.

This PR fixes:
- GitHub repository URLs (remove errant `ghcr.io/`)
- Homebrew tap references (`joshrotenberg/brew` → `redis-developer/homebrew-tap`)
- Documentation URLs (`joshrotenberg.github.io` → `redis-developer.github.io`)
- GHCR link in RELEASE.md checklist

Files updated:
- README.md
- RELEASE.md
- docs/src/getting-started/installation.md
- docs/src/introduction.md
- docs/src/presentation/slides.html

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants