feat(mcp): upgrade tower-mcp to 0.3.4 #622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshrotenberg
force-pushed
the
feat/tower-mcp-0.3.4-upgrade
branch
from
07ba4ee to
9a37549
Compare
Migrate all 68 MCP tools from the deprecated `handler_with_state` pattern
to the new axum-inspired extractor pattern using `State<T>` and `Json<T>`.
Changes:
- Update tower-mcp dependency from 0.2.3 to 0.3.4
- Migrate all tool handlers to use `extractor_handler_typed`
- Add `.build()` calls to PromptBuilder and ResourceBuilder chains
- Update integration test helpers for new CallToolResult API
- Remove cfg guard from AppState test helpers for better test ergonomics
Tool migration pattern:
Before: .handler_with_state(state, |state, input: T| async move {...})
After: .extractor_handler_typed::<_, _, _, T>(
state,
|State(state): State<Arc<AppState>>, Json(input): Json<T>| async move {...},
)
joshrotenberg
force-pushed
the
feat/tower-mcp-0.3.4-upgrade
branch
3 times, most recently
from
c30b146 to
ea0c534
Compare
joshrotenberg
force-pushed
the
feat/tower-mcp-0.3.4-upgrade
branch
from
ea0c534 to
38e9ae7
Compare
Same fix as for cargo-audit - the install-action is failing with "requires bash" error.
Fix integer overflow vulnerability in BytesMut::reserve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
State<T>+Json<T>).build()patternCallToolResultAPIChanges
The new tower-mcp 0.3.4 introduces a breaking change to the tool handler API:
Before:
After:
Files changed
crates/redisctl-mcp/Cargo.toml- version bumpcrates/redisctl-mcp/src/tools/cloud.rs- 18 tools migratedcrates/redisctl-mcp/src/tools/enterprise.rs- 25 tools migratedcrates/redisctl-mcp/src/tools/redis.rs- 18 tools migratedcrates/redisctl-mcp/src/tools/profile.rs- 7 tools migratedcrates/redisctl-mcp/src/prompts.rs- added.build()callscrates/redisctl-mcp/src/resources.rs- added.build()callscrates/redisctl-mcp/src/state.rs- test helper visibility fixTest plan
cargo fmt --all -- --checkcargo clippy -p redisctl-mcp --all-targets --all-features -- -D warningscargo test -p redisctl-mcp --lib(27 tests)cargo test -p redisctl-mcp --all-targets(75 tests total)