chore: consolidate workspace dependencies #640
Merged
+19
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert hardcoded dependency versions to workspace = true: - chrono, urlencoding, tower, keyring, tracing-subscriber - serial_test, tempfile in dev-dependencies Add new workspace deps: - tower (with full feature set for CLI and MCP) - keyring (for secure storage) - tempfile (for tests)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Consolidate dependency versions to use
workspace = truefor better consistency across crates.Changes
Converted to workspace deps:
chronoin redisctlurlencodingin redisctlkeyringin redisctl & redisctl-coretowerin redisctl & redisctl-mcptracing-subscriberin redisctl-mcpserial_testin redisctl & redisctl-core (dev)tempfilein redisctl & redisctl-core (dev)Added to workspace:
towerwith combined feature setkeyringwith platform-native featurestempfilefor testsTest plan
cargo check --workspacecargo fmt --all -- --checkcargo clippy --all-targets --all-features -- -D warnings