feat(enterprise): add curated table formatters for list/get commands#763
Merged
joshrotenberg merged 1 commit intomainfrom Mar 3, 2026
Merged
feat(enterprise): add curated table formatters for list/get commands#763joshrotenberg merged 1 commit intomainfrom
joshrotenberg merged 1 commit intomainfrom
Conversation
…761) Add #[derive(Tabled)] row structs to all Enterprise list and get commands, replacing the generic print_as_table() which dumped all JSON fields uncurated. This matches the Cloud command patterns established in PR #760. Row structs added: DatabaseRow, NodeRow, UserRow, RoleRow, AclRow, ModuleRow, ShardRow, ProxyRow. Get commands use DetailRow for vertical key-value display. Cluster get also uses DetailRow. Output branching uses resolve_auto() (now public) to render curated tables on TTY and pass through JSON/YAML for piped output. JMESPath queries are applied before table rendering.
This was referenced Mar 3, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[derive(Tabled)]row structs to all Enterprise list/get commands, replacing uncurated genericprint_as_table()outputDetailRow,extract_field,format_status,truncate_string,output_with_pager) fromenterprise/utils.rsand addformat_bytes()for RE API byte valuesresolve_auto()public inoutput.rsfor format branchingDatabaseRow,NodeRow,UserRow,RoleRow,AclRow,ModuleRow,ShardRow,ProxyRowDetailRowfor vertical key-value displayCloses #761
Test plan
cargo fmt --all -- --checkpassescargo clippy --all-targets --all-features -- -D warningspassescargo test --lib --all-features-- 89 tests passcargo test --test '*' --all-features-- 479 tests passredisctl enterprise database list,redisctl enterprise node list, etc.