feat(mcp): improve bulk_load for JSON seeding + collect_results flag#888
Merged
joshrotenberg merged 2 commits intomainfrom Mar 17, 2026
Merged
feat(mcp): improve bulk_load for JSON seeding + collect_results flag#888joshrotenberg merged 2 commits intomainfrom
joshrotenberg merged 2 commits intomainfrom
Conversation
Adds redis_json_mset which pipelines multiple JSON.SET calls in a single tool invocation, eliminating the N-tool-calls-for-N-docs friction during interactive prototyping sessions. Supports nx/xx flags (applied to all documents), returns per-document OK/skipped results plus a summary count. Closes #885.
Instead of a dedicated json_mset tool, solve the discoverability and per-result feedback problems in redis_bulk_load directly: - Description now explicitly calls out JSON.SET seeding as a primary use case with a concrete example, and documents NX/XX arg appending - collect_results=true (default false) opts out of fire-and-forget and returns per-command output (index, command, key, result), useful for small batches where NX/XX outcomes need to be verified Reverts the json_mset additions from json.rs. Closes #885.
joshrotenberg
changed the title
This was referenced Mar 17, 2026
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rather than adding a dedicated
json_msettool, this solves the root problems — discoverability and lack of per-result feedback — directly inredis_bulk_load:NX/XXto argscollect_resultsflag (defaultfalse): opt-in per-command result collection instead of fire-and-forget; returns index, command, key, and result for each command — useful for small batches where you need to verify NX/XX outcomesjson_msetadditions fromjson.rsWhy not a dedicated tool?
redis_bulk_loadalready handled batch JSON.SET — the gap was that agents didn't know to use it for that, and there was no way to see per-command results. Fixing those in the existing tool keeps the surface area smaller.Closes #885