Set retry_attempt more consistently for Error#final?
#259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underwoo16
force-pushed
the
retry-attempt-fixes
branch
2 times, most recently
from
583d0a5 to
85fa56a
Compare
|
Is there some more change you need to do, as in, do you still mean to keep this as a draft? |
Thanks for the ping, this is ready now 👍🏼 |
byroot
reviewed
Sep 28, 2025
byroot
force-pushed
the
retry-attempt-fixes
branch
3 times, most recently
from
649cb66 to
7500ee7
Compare
- During reconnection attempt - With Protocol errors - With Command errors (always final). Co-Authored-By: Jean Boussier <jean.boussier@gmail.com>
byroot
force-pushed
the
retry-attempt-fixes
branch
from
7500ee7 to
69cb23a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RedisClient::Error#final?incorrectly reported in various scenarios #258This sets
retry_attempton the connection before connect/reconnect so that error.final? is correct for errors during the connection processThis also sets
retry_attemptin the ruby connection for various errors raised during read/write, similar to what is implemented in the hiredis connection