Hiredis+sentinel don't re-use connections after a failover #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byroot
force-pushed
the
hiredis-reconnect
branch
from
c3e1ffb to
428e866
Compare
Fix: #257 The `hiredis` C library isn't capable of reconnecting to a different server, only to the same server. For classic client it's not a big deal, but with sentinel, a failover may have happened, hence the host or port may have changed.
byroot
force-pushed
the
hiredis-reconnect
branch
from
428e866 to
2e13847
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #257 (FYI: @Vasfed)
The
hiredisC library isn't capable of reconnecting to a different server, only to the same server.For classic client it's not a big deal, but with sentinel, a failover may have happened, hence the host or port may have changed.