Marc/resp3#478
Merged
Merged
Conversation
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
mgravell
added a commit
that referenced
this pull request
May 11, 2026
* fix RESP3 mismatches * dotnet format * Spoof RESP2 MRANGE results from RESP3 * fix double-incr * nits * fix rule parsing * fix info (flag) parsing * fix JSON APIs * fix spellcheck parsing * fix content from info result * Marc/resp3 (#477) * ft.config get * fix brittle TS.INFO tests (server version logic) * more runtime server version checks; profiled RESP3 layout * Marc/resp3 (#478) * ft.config get * fix brittle TS.INFO tests (server version logic) * more runtime server version checks; profiled RESP3 layout * dotnet format * the bot is right * - fix more search RESP3 behaviours - normalize time series test namespaces * deps * note GHATL pin * help me understand CI fail * add some key randomness to TestJsonSetNotExistAsync * add GetKeys helper to tell me what is missing in older servers * handle v7 RESP3 profile layout * dotnet format * more v7 fixings * and another * make the bugbot happy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches core response parsing for config and search profiling; incorrect assumptions about response shape could change returned data or throw at runtime if regressions slip in. Changes are small and targeted but affect common code paths.
Overview
Fixes a RESP2 parsing bug in
ResponseParser.ToConfigDictionarywhere jagged[ [key,value] ]responses were iterated with the wrong step, which could skip entries or index incorrectly.Corrects
ResponseParser.ToProfileSearchResultfor RESP3 so the parsedSearchResultfrom the"Results"section is actually assigned/returned. Includes a tiny whitespace-only cleanup in the testSkipIfRedis*Attributedefinitions.Reviewed by Cursor Bugbot for commit e7fcebd. Bugbot is set up for automated code reviews on this repo. Configure here.