[E2E] Redis Stack DB highlighting tests are added#412
Merged
Conversation
ofersteinberg
suggested changes
Mar 20, 2022
| await deleteDatabase(ossStandaloneConfig.databaseName); | ||
| }) | ||
| test | ||
| .meta({rte: rte.standalone}) |
There was a problem hiding this comment.
It's nice we have these tests, but couldn't it cover via component tests?
Contributor
Author
There was a problem hiding this comment.
We don't have compoent tests, only Unit. I asked developers if this functionality was covered by Unit and the answer is no. Let these E2E tests be for now (since they are already developed), but in the future we will cover such kind of tests from Unit side. Please let me know if you have any concerns.
ofersteinberg
approved these changes
Mar 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.