RI-7431: Change add key button view #4960
Conversation
ArtemHoruzhenko
commented
Sep 16, 2025
ArtemHoruzhenko
commented
| Before | After |
|---|---|
 |
 |
ArtemHoruzhenko
requested review from
KrumTy,
dantovska,
pawelangelow,
pd-redis and
valkirilov
as code owners
| } from 'uiSrc/telemetry' | ||
| import { | ||
| PrimaryButton, | ||
| Button, |
There was a problem hiding this comment.
nit: We also have an alias for a SecondaryButton that you can use :)
There was a problem hiding this comment.
Changed but I didn't like it. In general we added custom props to change the behavior and it became not clear which exactly variant we use.
There was a problem hiding this comment.
Usually, the goal of having semantics in the way we build up our design systems is to hide the "implementation details" and make the end result look consistent everywhere.
Yes, we can always use the base components and customize them however we want, but I believe this is what we wanted to avoid when @pd-redis's introduced these semantic aliases. Anyway, we can talk about this in the future, it's not something critical/important right now :)
ArtemHoruzhenko
dismissed stale reviews from valkirilov and pawelangelow
The base branch was changed.
Code Coverage - Frontend unit tests
Test suite run success5128 tests passing in 676 suites. Report generated by 🧪jest coverage report action from 3f61958 |
