RI-7431: fix key details header layout and rework confirmation popover #4971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ArtemHoruzhenko
commented
Sep 18, 2025
ArtemHoruzhenko
commented
| Before | After |
|---|---|
 |
 |
 |
 |
 |
 |
ArtemHoruzhenko
requested review from
KrumTy,
dantovska,
pawelangelow,
pd-redis and
valkirilov
as code owners
Contributor
Code Coverage - Frontend unit tests
Test suite run success5149 tests passing in 677 suites. Report generated by 🧪jest coverage report action from 3df2f1a |
dantovska
reviewed
Sep 18, 2025
Comment on lines
177
to
178
| <FlexItem grow /> | ||
| <FlexItem> |
Contributor
There was a problem hiding this comment.
This is wrong... Please separate this flex box in two main boxes and use justify-content: space-between to move the refresh to the end.
ArtemHoruzhenko
force-pushed
the
fe/feature/RI-7431-fix-key-deatils-header-and-confirmation-popover
branch
from
1645944 to
3df2f1a
Compare
dantovska
reviewed
Sep 18, 2025
Comment on lines
+1
to
+3
| import React from 'react' | ||
| import { RiPopover, RiPopoverProps } from 'uiSrc/components' | ||
| import styled from 'styled-components' |
Contributor
There was a problem hiding this comment.
nit: these should be ordered
dantovska
approved these changes
Sep 18, 2025
ArtemHoruzhenko
deleted the
fe/feature/RI-7431-fix-key-deatils-header-and-confirmation-popover
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.