Skip to content

RI-7461: Unable to edit string key in JSON formatter #4977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2025
Merged

RI-7461: Unable to edit string key in JSON formatter #4977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion redisinsight/ui/src/components/base/utils/OutsideClickDetector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export interface OutsideClickDetectorProps {
// A click event's target can be imprecise, as the value will be
// the closest common ancestor of the press (mousedown, touchstart)
// and release (mouseup, touchend) events (often <body />) if
// the the target of each event differs.
// the target of each event differs.
// We need the actual event targets to make the correct decisions
// about user intention. So, consider the down/start and up/end
// items below as the deconstruction of a click event.
Expand Down
6 changes: 4 additions & 2 deletions redisinsight/ui/src/components/inline-item-editor/InlineItemEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import {
StyledTextInput,
} from './InlineItemEditor.styles'


import styles from './styles.module.scss'

type Positions = 'top' | 'bottom' | 'left' | 'right' | 'inside'
Expand Down Expand Up @@ -216,7 +215,10 @@ const InlineItemEditor = (props: Props) => {
{viewChildrenMode ? (
children
) : (
<OutsideClickDetector onOutsideClick={handleClickOutside}>
<OutsideClickDetector
onOutsideClick={handleClickOutside}
isDisabled={isShowApprovePopover}
>
<IIEContainer ref={containerEl}>
<WindowEvent event="keydown" handler={handleOnEsc} />
<FocusTrap disabled={disableFocusTrap}>
Expand Down
Loading