Skip to content

Conversation

@ArtemHoruzhenko
Copy link
Contributor

@ArtemHoruzhenko ArtemHoruzhenko commented Sep 23, 2025

  1. Disable onboarding (set appropriate local storage flag) after index created on vector search multi-step form
  2. Reworked ff for vector search to hide onboarding multi-step form and promotion button when ff disabled

@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2025

Code Coverage - Frontend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 82.14% 19995/24343
🟡 Branches 67.52% 8667/12836
🟡 Functions 76.25% 5321/6978
🟢 Lines 82.57% 19578/23711

Test suite run success

5155 tests passing in 677 suites.

Report generated by 🧪jest coverage report action from 3fcdd8e

Copy link
Member

@valkirilov valkirilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! 🙌

We have the "Getting Started" button on a few more places, so I guess we should add the feature flag there as well:

  • Query Results, when you don't have any searches yet
  • Manage Indexes panel, when you don't have any indexes
  • Saved Queries panel, when you don't have any indexes
Image

I believe this is the single place you can change:

}, [step])

useEffect(() => {
console.log('___ success/error changed!!!!', { success, error })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you forgot to clean up this after debugging something.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was checking how review is happening.
Now I know that it is ok 👍

@ArtemHoruzhenko
Copy link
Contributor Author

Nice job! 🙌

We have the "Getting Started" button on a few more places, so I guess we should add the feature flag there as well:

  • Query Results, when you don't have any searches yet
  • Manage Indexes panel, when you don't have any indexes
  • Saved Queries panel, when you don't have any indexes
Image I believe this is the single place you can change:

Good catch!
Covered few more places

FF Enabled FF Disabled
Screenshot 2025-09-24 at 13 09 08 Screenshot 2025-09-24 at 13 08 55

valkirilov
valkirilov previously approved these changes Sep 24, 2025
@ArtemHoruzhenko ArtemHoruzhenko merged commit c41c10c into main Sep 25, 2025
26 of 32 checks passed
@ArtemHoruzhenko ArtemHoruzhenko deleted the fe/feature/RI-7546-get-started-page-ff-and-show-flag branch September 25, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants