-
Notifications
You must be signed in to change notification settings - Fork 421
Fe/feature/ri 7546 get started page ff and show flag #4981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fe/feature/ri 7546 get started page ff and show flag #4981
Conversation
Code Coverage - Frontend unit tests
Test suite run success5155 tests passing in 677 suites. Report generated by 🧪jest coverage report action from 3fcdd8e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! 🙌
We have the "Getting Started" button on a few more places, so I guess we should add the feature flag there as well:
- Query Results, when you don't have any searches yet
- Manage Indexes panel, when you don't have any indexes
- Saved Queries panel, when you don't have any indexes
I believe this is the single place you can change:
| }, [step]) | ||
|
|
||
| useEffect(() => { | ||
| console.log('___ success/error changed!!!!', { success, error }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you forgot to clean up this after debugging something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was checking how review is happening.
Now I know that it is ok 👍



Uh oh!
There was an error while loading. Please reload this page.