RI-7831: add semantic version utils #5261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Modules - Add convertToSemanticVersion function to convert numeric versions to semantic format - Add ensureSemanticVersion function with null safety checks for instance modules - Create comprehensive test suite using DBInstanceFactory and it.each patterns
pd-redis
requested review from
ArtemHoruzhenko,
DimoHG,
KrumTy,
dantovska,
pawelangelow,
tptodorov and
valkirilov
as code owners
valkirilov
previously approved these changes
Nov 28, 2025
Member
|
It's not related to the introduced changes, but it looks like there are some issues on the backend as well, because it's reporting weird versions. 
|
Update test to include properties that reducer sets: loading, isRediStack, isFreeDb, and db. References: #RI-7831
valkirilov
approved these changes
Nov 28, 2025
Contributor
Code Coverage - Frontend unit tests
Test suite run success5447 tests passing in 704 suites. Report generated by 🧪jest coverage report action from e8c90fe |
Contributor
Author
I am not sure it is the backend that reports this, but for sure you can issue an INFO command and check what actual version is. If there is difference, then definitely this is a bug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixed semantic version display for Redis modules that are not explicitly supported in the backend mapping. The issue occurred when modules like
redisgears_2would display raw numeric versions instead of properly formatted semantic versions (e.g., "20000" instead of "2.0.0").Technical decisions:
ensureSemanticVersionutility that converts numeric versions to semantic format whensemanticVersionis missingTesting
Load standalone redis v7.4 in RI, open the instance, hover over the info icon in top left corner.
Resolves: RI-7831
Note
Adds utilities to convert module versions to semantic format and applies them when loading/connecting instances, with accompanying tests.
ensureSemanticVersionandconvertToSemanticVersioninutils/instance/instanceModules.tsto normalize numeric module versions to semantic format; enhancegetModule.slices/instances/instances.ts):ensureSemanticVersionto instance data inloadInstancesSuccessandsetConnectedInstanceSuccess.utils/instance/instanceModules.spec.tsfor module lookup and version normalization.instances.spec.tsexpectations forsetConnectedInstanceSuccessto reflect normalized instance shape.Written by Cursor Bugbot for commit e8c90fe. This will update automatically on new commits. Configure here.