Skip to content

Conversation

@KrumTy
Copy link
Contributor

@KrumTy KrumTy commented Nov 28, 2025

What

Fixes:

  • broken layout (page spacings, etc)
  • table headers not being shown
  • sorting crashes the app
  • max value of column not being bolded
  • cut table borders

Due to amount of fixes, I've also refactored the whole table to follow the new style guidelines.

Testing

  1. Go to a cluster node's analysis -> overview page

Before

Screen.Recording.2025-11-28.at.12.47.46.mov

After

Screen.Recording.2025-11-28.at.12.43.44.mov

Loading state

Screenshot 2025-11-28 at 12 54 06

Note

Refactors the Cluster Details table and page layout to the new table API with styled-components, adds formatting/max-value logic and tests, and removes the old implementation.

  • Cluster Details (UI)
    • Replace styles.module.scss with styled-components wrapper ClusterDetailsPage.styles.ts and simplify layout.
    • Compute nodes via useMemo and pass to ClusterDetailsGraphics/ClusterNodesTable.
  • ClusterNodesTable
    • Reimplemented using Table with DEFAULT_CLUSTER_NODES_COLUMNS and DEFAULT_SORTING (sort by host).
    • Split into cells: ClusterNodesHostCell (letter/host/port with color indicator) and ClusterNodesNumericCell (formats values, tooltips, highlights unique max).
    • Added loading empty state component and capped table height.
    • Updated exports and usages; removed legacy cluser-nodes-table and SCSS.
  • Testing & Mocks
    • Added unit tests for table and numeric cell logic, including max-value behavior and formatting.
    • Introduced ClusterNodeDetailsFactory for generating mock node data.

Written by Cursor Bugbot for commit 0da6f0a. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

Code Coverage - Frontend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 82.93% 20980/25298
🟡 Branches 68.15% 8851/12987
🟡 Functions 78.02% 5730/7344
🟢 Lines 83.34% 20545/24652

Test suite run success

5474 tests passing in 705 suites.

Report generated by 🧪jest coverage report action from 0da6f0a

@KrumTy KrumTy merged commit 79f21b7 into main Nov 28, 2025
19 checks passed
@KrumTy KrumTy deleted the fe/RI-7786/fix-cluster-nodes-table branch November 28, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants